[v18.x backport] esm: add --import flag#49539
Closed
aduh95 wants to merge 2 commits intonodejs:v18.x-stagingfrom
Closed
[v18.x backport] esm: add --import flag#49539aduh95 wants to merge 2 commits intonodejs:v18.x-stagingfrom
--import flag#49539aduh95 wants to merge 2 commits intonodejs:v18.x-stagingfrom
Conversation
PR-URL: nodejs#43942 Fixes: nodejs#40110 Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: nodejs#44067 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Collaborator
|
Review requested:
|
nodejs-github-bot
added
lib / src
GeoffreyBooth
approved these changes
Sep 7, 2023
Member
GeoffreyBooth
left a comment
GeoffreyBooth
left a comment
There was a problem hiding this comment.
I think we can mark it as stable at this point, but that can follow in another PR.
MoLow
approved these changes
Sep 7, 2023
Collaborator
Member
|
Landed in 097dea0...aaaa54d |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports:
--importflag #43942--importas experimental #44067